Skip to content

fix: remove duplicate NOTICE file under bin/single-node#5303

Merged
Yicong-Huang merged 2 commits into
apache:mainfrom
Ma77Ball:remove-duplicate-notice-single-node
May 31, 2026
Merged

fix: remove duplicate NOTICE file under bin/single-node#5303
Yicong-Huang merged 2 commits into
apache:mainfrom
Ma77Ball:remove-duplicate-notice-single-node

Conversation

@Ma77Ball
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

  • Removed the duplicate NOTICE file under bin/single-node/, which was identical to the project root NOTICE, to avoid the two-copy drift problem.
  • Updated .github/workflows/create-release-candidate.yml so the Docker Compose release bundle still includes a NOTICE, now sourced from the root copy (added NOTICE to the git archive paths and repointed the cp).

Any related issues, documentation, or discussions?

Closes: #5296

How was this PR tested?

  • Verified the root NOTICE and removed bin/single-node/NOTICE were byte-for-byte identical before deletion.
  • Grepped the repo to confirm the release workflow was the only reference, and updated it so the bundle copy still resolves.

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.7 in compliance with ASF

@github-actions github-actions Bot added ci changes related to CI dev labels May 31, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.76%. Comparing base (1b0ec78) to head (51c8351).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5303      +/-   ##
============================================
- Coverage     49.78%   49.76%   -0.02%     
+ Complexity     2415     2412       -3     
============================================
  Files          1052     1052              
  Lines         40755    40755              
  Branches       4355     4355              
============================================
- Hits          20289    20283       -6     
- Misses        19256    19259       +3     
- Partials       1210     1213       +3     
Flag Coverage Δ
access-control-service 41.89% <ø> (ø)
agent-service 33.76% <ø> (ø)
amber 51.97% <ø> (-0.04%) ⬇️
computing-unit-managing-service 0.00% <ø> (ø)
config-service 0.00% <ø> (ø)
file-service 38.42% <ø> (ø)
frontend 42.22% <ø> (ø)
python 90.80% <ø> (ø)
workflow-compiling-service 56.81% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ma77Ball Ma77Ball changed the title Remove duplicate NOTICE file under bin/single-node fix: Remove duplicate NOTICE file under bin/single-node May 31, 2026
@Ma77Ball
Copy link
Copy Markdown
Contributor Author

/request-review @bobbai00

@github-actions github-actions Bot requested a review from bobbai00 May 31, 2026 21:44
Comment thread .github/workflows/create-release-candidate.yml
@bobbai00 bobbai00 changed the title fix: Remove duplicate NOTICE file under bin/single-node fix: remove duplicate NOTICE file under bin/single-node May 31, 2026
@Yicong-Huang Yicong-Huang added this pull request to the merge queue May 31, 2026
Merged via the queue into apache:main with commit ab79ea4 May 31, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the duplicate NOTICE file under bin/single-node

4 participants